Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds the CalendarTimeStrategy #195

Merged
merged 2 commits into from
Dec 16, 2013
Merged

Adds the CalendarTimeStrategy #195

merged 2 commits into from
Dec 16, 2013

Conversation

ianoc
Copy link
Collaborator

@ianoc ianoc commented Dec 14, 2013

No description provided.

johnynek
johnynek reviewed Dec 14, 2013
View reviewed changes
...haus-algebra/src/main/scala/com/twitter/storehaus/algebra/query/CalendarTimeQueryRange.scala
import java.util.TimeZone
import scala.annotation.tailrec

case class Bucket(typeIndx: Int, startTime: Long) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CalendarBucket perhaps?

@ianoc
Copy link
Collaborator Author

ianoc commented Dec 15, 2013

Updated based on comments // removed object that could just be combined into the strategy

johnynek added a commit that referenced this pull request Dec 16, 2013
@johnynek
Merge pull request #195 from twitter/feature/calendarQueryStrategy2
a4edba9 
Adds the CalendarTimeStrategy
@johnynek johnynek merged commit a4edba9 into develop Dec 16, 2013
@johnynek johnynek deleted the feature/calendarQueryStrategy2 branch December 16, 2013 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ianoc @johnynek